Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pt mesh #9

Merged
merged 8 commits into from
Mar 14, 2019
Merged

Conversation

kerautret
Copy link

Fix for the mesh, to answer to you question:

while compiling testMesh.cpp, there is a conversion error in Mesh.ih. The problem is that the Mesh vertex have integer component (is that always the case ?) and those components are here scaled by a double thus leading to an invalid conversion (ping @kerautret).

Mesh do not have necessary an integer point (also used to display std mesh in various viewer of DGtalTools). I corrected the scale which was indeed not correct and I force to be of the same type than the point component. I fix the test and typo in the doc (sorry my PR contains also other fix but I/you can cherrypick if you want let me know). By the way many thanks for the details and listing ;)

@rolanddenis
Copy link
Owner

All good for me, merging ... Thanks!

@rolanddenis rolanddenis merged commit dafb5d8 into rolanddenis:fix_pointvector Mar 14, 2019
This was referenced Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants